[OpenJDK 2D-Dev] RFR: 8271456: Avoid looking up standard charsets in "java.desktop" module [v3]
serb at openjdk.java.net
Tue Aug 3 23:35:55 UTC 2021
> This is a request to clean up a desktop module as was done in JDK-8233884 for "java.base" module.
> In many places standard charsets are looked up via their names, for example:
> This could be done more efficiently(x20 time faster) with use of java.nio.charset.StandardCharsets:
> The later variant also makes the code cleaner, as it is known not to throw UnsupportedEncodingException in contrary to the former variant.
> Tested by the desktop headless/headful tests on linux/windows.
Sergey Bylokhov has updated the pull request incrementally with one additional commit since the last revision:
static import StandardCharsets
- all: https://git.openjdk.java.net/jdk/pull/4951/files
- new: https://git.openjdk.java.net/jdk/pull/4951/files/886264aa..e4e82c83
- full: https://webrevs.openjdk.java.net/?repo=jdk&pr=4951&range=02
- incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=4951&range=01-02
Stats: 245 lines in 31 files changed: 93 ins; 63 del; 89 mod
Fetch: git fetch https://git.openjdk.java.net/jdk pull/4951/head:pull/4951
More information about the 2d-dev