[OpenJDK 2D-Dev] RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v24]
aph at openjdk.java.net
Fri Mar 12 16:35:23 UTC 2021
On Tue, 9 Mar 2021 16:12:36 GMT, Anton Kozlov <akozlov at openjdk.org> wrote:
>> Please review the implementation of JEP 391: macOS/AArch64 Port.
>> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and windows/aarch64.
>> Major changes are in:
>> * src/hotspot/cpu/aarch64: support of the new calling convention (subtasks JDK-8253817, JDK-8253818)
>> * src/hotspot/os_cpu/bsd_aarch64: copy of os_cpu/linux_aarch64 with necessary adjustments (JDK-8253819)
>> * src/hotspot/share, test/hotspot/gtest: support of write-xor-execute (W^X), required on macOS/AArch64 platform. It's implemented with pthread_jit_write_protect_np provided by Apple. The W^X mode is local to a thread, so W^X mode change relates to the java thread state change (for java threads). In most cases, JVM executes in write-only mode, except when calling a generated stub like SafeFetch, which requires a temporary switch to execute-only mode. The same execute-only mode is enabled when a java thread executes in java or native states. This approach of managing W^X mode turned out to be simple and efficient enough.
>> * src/jdk.hotspot.agent: serviceability agent implementation (JDK-8254941)
> Anton Kozlov has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 105 commits:
> - Merge commit 'refs/pull/11/head' of https://github.com/AntonKozlov/jdk into jdk-macos
> - workaround JDK-8262895 by disabling subtest
> - Fix typo
> - Rename threadWXSetters.hpp -> threadWXSetters.inline.hpp
> - JDK-8259937: bsd_aarch64 part
> - Merge remote-tracking branch 'upstream/jdk/master' into jdk-macos
> - Fix after JDK-8259539, partially revert preconditions
> - JDK-8260471: bsd_aarch64 part
> - JDK-8259539: bsd_aarch64 part
> - JDK-8257828: bsd_aarch64 part
> - ... and 95 more: https://git.openjdk.java.net/jdk/compare/a6e34b3d...a72f6834
> @theRealAph, could you elaborate on what is need to be done for [#2200 (review)](https://github.com/openjdk/jdk/pull/2200#pullrequestreview-600597066).
I think that what you've got now is fine.
Marked as reviewed by aph (Reviewer).
More information about the 2d-dev