<div dir="ltr"><div>Kevin & Philip,<br></div><div><br></div><div>Thank you for your reviews, I pushed the fix:<br></div><div><a href="http://hg.openjdk.java.net/jdk/client/rev/13178f7e75d5">http://hg.openjdk.java.net/jdk/client/rev/13178f7e75d5</a></div><div><br></div><div>Laurent<br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">Le mer. 7 août 2019 à 01:30, Kevin Rushforth <<a href="mailto:kevin.rushforth@oracle.com">kevin.rushforth@oracle.com</a>> a écrit :<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
  
    
  
  <div bgcolor="#FFFFFF">
    Looks good.<br>
    <br>
    +1<br>
    <br>
    -- Kevin<br>
    <br>
    <div class="gmail-m_8457819702982098100moz-cite-prefix">On 8/6/2019 12:28 AM, Laurent Bourgès
      wrote:<br>
    </div>
    <blockquote type="cite">
      
      <div dir="auto">
        <div dir="auto">Ping:</div>
        <div dir="auto">Could someone do a second review ?</div>
        <div dir="auto">Laurent</div>
      </div>
      <br>
      <div class="gmail_quote">
        <div dir="ltr" class="gmail_attr">Le ven. 2 août 2019 à 17:01,
          Laurent Bourgès <<a href="mailto:bourges.laurent@gmail.com" target="_blank">bourges.laurent@gmail.com</a>> a
          écrit :<br>
        </div>
        <blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
          <div dir="ltr">
            <div>Thanks Philip,</div>
            <div><br>
            </div>
            <div>I am waiting for another approval,</div>
            <div>Cheers,</div>
            <div>Laurent<br>
            </div>
          </div>
          <br>
          <div class="gmail_quote">
            <div dir="ltr" class="gmail_attr">Le ven. 2 août 2019
              à 00:13, Philip Race <<a href="mailto:philip.race@oracle.com" rel="noreferrer" target="_blank">philip.race@oracle.com</a>>
              a écrit :<br>
            </div>
            <blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">+1 from me. Looks the
              same as the FX fix modulo some moving things around.<br>
              <br>
              -phil.<br>
              <br>
              On 7/29/19, 12:56 AM, Laurent Bourgès wrote:<br>
              > Hi,<br>
              ><br>
              > Please review this bug fix for the Marlin renderer
              (introduced in <br>
              > JDK11.0.2):<br>
              > JBS: <a href="https://bugs.openjdk.java.net/browse/JDK-8228711" rel="noreferrer noreferrer" target="_blank">https://bugs.openjdk.java.net/browse/JDK-8228711</a><br>
              > webrev: <a href="http://cr.openjdk.java.net/~lbourges/marlin/marlin-8228711.0/" rel="noreferrer noreferrer" target="_blank">http://cr.openjdk.java.net/~lbourges/marlin/marlin-8228711.0/</a>
              <br>
              > <<a href="http://cr.openjdk.java.net/%7Elbourges/marlin/marlin-8228711.0/" rel="noreferrer noreferrer" target="_blank">http://cr.openjdk.java.net/%7Elbourges/marlin/marlin-8228711.0/</a>><br>
              ><br>
              > This patch is very close to MarlinFX patch integrated
              last week in <br>
              > OpenJFX 14, see <a href="https://bugs.openjdk.java.net/browse/JDK-8226789" rel="noreferrer noreferrer" target="_blank">https://bugs.openjdk.java.net/browse/JDK-8226789</a><br>
              ><br>
              > Changes:<br>
              > - Stroker: fixed closePath() to preserve last
              position and its outcode<br>
              > - TransformingPathConsumer2D: fixed
              PathClipFilter.closePath() to <br>
              > preserve last position and its outcode<br>
              > - Dasher: better precision handling (comparison float
              value with epsilon)<br>
              > - ClipShapeTest: use preliminary curve subdivision
              (length > 50px) to <br>
              > avoid false positives on long stroked curves (quad /
              cubic) + lowered <br>
              > thresholds<br>
              ><br>
              > Cheers,<br>
              > Laurent<br>
            </blockquote>
          </div>
          <br clear="all">
          <br>
          -- <br>
          <div dir="ltr" class="gmail-m_8457819702982098100m_5324395789867481066gmail_signature">--
            <br>
            Laurent Bourgès</div>
        </blockquote>
      </div>
    </blockquote>
    <br>
  </div>

</blockquote></div><br clear="all"><br>-- <br><div dir="ltr" class="gmail_signature">-- <br>Laurent Bourgès</div>