<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
  </head>
  <body>
    <p>Hi everyone.</p>
    <p>Thanks for the feedback!</p>
    <p>Firstly, I changed the wording from 'Creates' to 'Constructs' as
      per Philip's suggestion (and corrected a spelling mistake).</p>
    <p>Secondly, for the protected constructors (in the abstract
      classes) I used the wording "Constructor for subclasses to call."
      as that seems to be the norm now.</p>
    <ul>
      <li>webrev: <a
href="http://cr.openjdk.java.net/~ccleary/issues/webrevs-store/8250855/webrevs/webrev.02/">http://cr.openjdk.java.net/~ccleary/issues/webrevs-store/8250855/webrevs/webrev.02/</a></li>
      <li>specdiff: <a
href="http://cr.openjdk.java.net/~ccleary/issues/webrevs-store/8250855/webrevs/webrev.02/specdiff/overview-summary.html">http://cr.openjdk.java.net/~ccleary/issues/webrevs-store/8250855/webrevs/webrev.02/specdiff/overview-summary.html</a></li>
      <li>CSR: <a
          href="https://bugs.openjdk.java.net/browse/JDK-8252495">https://bugs.openjdk.java.net/browse/JDK-8252495</a></li>
      <li>bug: <a
          href="https://bugs.openjdk.java.net/browse/JDK-8250859">https://bugs.openjdk.java.net/browse/JDK-8250859</a></li>
    </ul>
    <p>Regards,</p>
    <p>Conor<br>
    </p>
    <div class="moz-cite-prefix">On 31/08/2020 21:15, Philip Race wrote:<br>
    </div>
    <blockquote type="cite" cite="mid:5F4D5A6A.90009@oracle.com">Right
      we have started to be consistent using "Constructor for subclasses
      to call":
      <br>
      <br>
      Also I prefer constructs over creates, even for the concrete
      classes, eg this :
      <br>
      +
      <br>
      +    /**
      <br>
      +     * Creates an {@code ImageFilter}.
      <br>
      +     */
      <br>
      +    public ImageFilter() {}
      <br>
      +
      <br>
      <br>
      should be "Constructs an {@code ImageFilter}"
      <br>
      <br>
      -phil.
      <br>
      <br>
      On 8/28/20, 5:29 PM, Sergey Bylokhov wrote:
      <br>
      <blockquote type="cite">Hi, Conor.
        <br>
        <br>
        Please use such spec for the protected constructor: "Constructor
        for subclasses to call":
        <br>
<a class="moz-txt-link-freetext" href="https://cr.openjdk.java.net/~psadhukhan/8250850/webrev.1/src/java.desktop/share/classes/javax/swing/plaf/metal/MetalTheme.java.sdiff.html">https://cr.openjdk.java.net/~psadhukhan/8250850/webrev.1/src/java.desktop/share/classes/javax/swing/plaf/metal/MetalTheme.java.sdiff.html</a>
        <br>
        <br>
        Actually the current text is also fine to me, but looks like
        many people use the text above as a description.
        <br>
        <br>
        On 28.08.2020 01:28, Conor Cleary wrote:
        <br>
        <blockquote type="cite">Hello all,
          <br>
          <br>
          Could someone please review my changes for JDK-8250855,
          'Address reliance on default constructors in the Java 2D
          APIs'? This issue relates to JDK-8250639 '☂ Address reliance
          on default constructors in the java.desktop module'. The
          changes address the reliance on default constructors by adding
          in basic constructors in the following classes:
          <br>
          <br>
            * java.awt.Image
          <br>
            * java.awt.PrintJob
          <br>
            * java.awt.font.GlyphVector
          <br>
            * java.awt.font.LayoutPath
          <br>
            * java.awt.font.LineMetrics
          <br>
            * java.awt.image.AbstractMultiResolutionImage
          <br>
            * java.awt.image.BufferStrategy
          <br>
            * java.awt.image.ImageFilter
          <br>
            * java.awt.image.RGBImageFilter
          <br>
            * java.awt.image.VolatileImage
          <br>
            * javax.print.PrintServiceLookup
          <br>
            * javax.print.ServiceUI
          <br>
            * javax.print.ServiceUIFactory
          <br>
            * javax.print.StreamPrintServiceFactory
          <br>
            * javax.print.event.PrintJobAdapter
          <br>
          <br>
          A key issue is the accompanying description for each of the
          added constructors and is probably the feedback I would value
          most as it has been a point of discussion previously. I have
          included a specdiff to easily view the changes observed in the
          api documentation. Currently drafting a CSR for these changes.
          <br>
          <br>
            * webrev:
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~ccleary/issues/webrevs-store/8250855/webrevs/webrev.01/">http://cr.openjdk.java.net/~ccleary/issues/webrevs-store/8250855/webrevs/webrev.01/</a><br>
            * specdiff:
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~ccleary/issues/webrevs-store/8250855/webrevs/webrev.01/specdiff/overview-summary.html">http://cr.openjdk.java.net/~ccleary/issues/webrevs-store/8250855/webrevs/webrev.01/specdiff/overview-summary.html</a><br>
            * bug: <a class="moz-txt-link-freetext" href="https://bugs.openjdk.java.net/browse/JDK-8250855">https://bugs.openjdk.java.net/browse/JDK-8250855</a>
          <br>
          <br>
          Best Regards,
          <br>
          <br>
          -Conor
          <br>
          <br>
        </blockquote>
        <br>
        <br>
      </blockquote>
    </blockquote>
  </body>
</html>