[aarch64-port-dev ] RFR: 8165404: AArch64: Implement SHA512 accelerator/intrinsic
felix.yang at huawei.com
Fri Aug 7 06:20:25 UTC 2020
> -----Original Message-----
> From: Andrew Haley [mailto:aph at redhat.com]
> Sent: Thursday, August 6, 2020 7:42 PM
> To: Yangfei (Felix) <felix.yang at huawei.com>; hotspot-runtime-
> dev at openjdk.java.net
> Cc: aarch64-port-dev at openjdk.java.net
> Subject: Re: RFR: 8165404: AArch64: Implement SHA512 accelerator/intrinsic
> On 8/6/20 2:13 AM, Yangfei (Felix) wrote:
> > I have added tests for sha512 crypto instructions in this script and
> regenerated the code.
> > Tier1-3 tested with an aarch64 fastdebug build on my aarch64 linux host to
> cover this part.
> > Updated webrev: http://cr.openjdk.java.net/~fyang/8165404/webrev.02/
> > Is it OK?
> Yes, thanks.
> It's a bit annoying that the indentation seems to change so frequently. I'm
> wondering if perhaps some people have been running this on Windows,
> which has different tab sizes, but that seems very unlikely, given that this is a
> Linux port. But never mind, that's not your problem.
I see the output of the python script contains tabs which is not allowed by jcheck.
So I guess it may depends on the way in which people substitute these tabs.
I used vim editor to do the replacement, which is simple.
Open the file which contains the script output and do:
Looks like the indentation is more consistent this way. Hope that helps.
Pushed as: https://hg.openjdk.java.net/jdk/jdk/rev/09ad5b67a099
More information about the aarch64-port-dev