[aarch64-port-dev ] RFR(L): 8231441: AArch64: Initial SVE backend support
aph at redhat.com
Thu Aug 20 09:08:18 UTC 2020
On 20/08/2020 09:58, Nick Gasson wrote:
> On 08/20/20 16:48 pm, Andrew Dinn wrote:
>>> It is perhaps a bit strange to have the test code under src/ and
>>> embedded in the assembler implementation. How about we move it under
>>> test/ using the existing gtest framework for native code tests? That
>>> runs in tier1 and also for release builds. I tried this just now and
>>> it's easy to do.
>> I'm not sure that would be an improvement. This python code is used to
>> generate C code run as part of JVM startup in a debug JVM build i.e.
>> code that is linked into the JVM itself. So, the code it generates is
>> really the same as the debug code embedded in the JVM. It doesn't really
>> bear any relation to the code in the test tree.
> I meant move the test itself - entry() and asm_check() in
> assembler_aarch64.cpp - under test/hotspot/gtest. The generator would
> move with it.
Hmm. I'm still not sure how this would work. Let's see the patch and
we can talk about it. It still sounds to me rather like pointlessly
moving the furniture around.
Andrew Haley (he/him)
Java Platform Lead Engineer
Red Hat UK Ltd. <https://www.redhat.com>
EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671
More information about the aarch64-port-dev