[aarch64-port-dev ] RFR (XS) 8252366: Shenandoah: revert/cleanup changes in graphKit.cpp

Roman Kennke rkennke at redhat.com
Wed Aug 26 10:13:39 UTC 2020

Am Mittwoch, den 26.08.2020, 11:10 +0200 schrieb Roland Westrelin:
> > This is aarch64-port/jdk8u-shenandoah specific issue:
> >    https://bugs.openjdk.java.net/browse/JDK-8252366
> > 
> > The assert seems to fail on ppc64. Also, we might inline
> > g1_write_barrier_pre_helper for clarity.
> > 
> > 8u webrev:
> >    https://cr.openjdk.java.net/~shade/8252366/webrev.01/
> I don't see where on this code path a load barrier would be added. Am
> I
> missing something?

It looks like we added this assert there:
  assert(elembt != T_OBJECT && elembt != T_ARRAY, "sanity");

(which you actually removed in your patch)

It looks like this is not actually used for reference types. The only
uses are in library_call.cpp and they don't look like they ever load a
reference. Please check and confirm to be sure.


More information about the aarch64-port-dev mailing list