[aarch64-port-dev ] RFR (XS) 8252366: Shenandoah: revert/cleanup changes in graphKit.cpp

Aleksey Shipilev shade at redhat.com
Wed Aug 26 11:08:52 UTC 2020

On 8/26/20 1:01 PM, Roland Westrelin wrote:
>> It looks like this is not actually used for reference types. The only
>> uses are in library_call.cpp and they don't look like they ever load a
>> reference. Please check and confirm to be sure.
> It does on PPC. In LibraryCallKit::get_key_start_from_aescrypt_object().

Yes. I misjudged the assert: it actually verifies the current Shenandoah uses do not need the LRB 
there. Shenandoah is not supported (yet) on PPC, so there is no bug yet, and assert is just too 
strong for PPC code. But it feels more future proof just to insert the Shenandoah barrier there.

8u webrev:

Testing: hotspot_gc_shenandoah {fastdebug,release}


More information about the aarch64-port-dev mailing list