RFR: 8195850: Improve startup of code to pull arguments from BootstrapMethodInvoker

Paul Sandoz paul.sandoz at oracle.com
Mon Jan 22 21:58:46 UTC 2018


Looks good:

Since you have been wrapping such things in braces you might as well do the same for:
 405         if (TRACE_METHOD_LINKAGE)
 406             System.out.println("converting BSM of type " + bsm.type() + " to "
 407                     + (goToPushMode ? "push mode" : "pull mode"));

We will need to follow up with another issue to import the changeset into the main repo once condy gets pushed (we are nearly there, things stalled during the holidays, just waiting on the last finalized CSR to be approved).


> On Jan 22, 2018, at 6:22 AM, Claes Redestad <claes.redestad at oracle.com> wrote:
> Hi,
> a startup inefficiency was detected in the BootstrapMethodInvoker when arranging
> for the BootstrapMethodInvoker to pull arguments from the VM, where we can arrange
> to initialize the different adapters more lazily, and avoid invokeWithArguments:
> http://cr.openjdk.java.net/~redestad/8195850/open.00/
> The inefficiency can be provoked on a version of CondyNestedTest.java[1] modified
> to be compilable and runnable without any dependencies. Quite a bit of setup,
> is avoided - in this test I see a 7-8% reduction in bytecode executed (mixed mode).
> Thanks!
> /Claes
> [1] http://cr.openjdk.java.net/~redestad/8195850/CondyNestedTest.java

More information about the amber-dev mailing list