<AWT Dev> Review request #2: 6852592 (revalidate() must be smarter)

Anthony Petrov Anthony.Petrov at Sun.COM
Tue Jul 21 03:13:55 PDT 2009

Hi Artem,

On 07/20/2009 11:01 AM, Artem Ananiev wrote:
> I see a number of isValidateRoot() methods in Swing code besides in 
> JComponent class. Probably, all of them could be linked (@see tag) to 
> Container.isValidateRoot() as well?
Yeah, that's a good suggestion. Done.

> Another idea is to override this method to return true for Window and 
> Applet classes. This would simplify a code in a RepaintManager class, 
> for example.
Indeed, overriding it for Window and Applet makes sense. Though I would 
like to avoid hacking the Swing code much with this fix. Perhaps we 
should file a separate CR for the optimization task?

best regards,

>> This is the next version of the fix for the issue with the 
>> invalidate()/isValidateRoot() methods. The webrev:
>> http://cr.openjdk.java.net/~anthony/7-23-invalidate-6852592.1/

More information about the awt-dev mailing list