<AWT Dev> XToolkit beep does not work consistently

Artem Ananiev Artem.Ananiev at Sun.COM
Sun Jun 21 19:18:08 PDT 2009

Lillian Angel wrote:
> Anthony Petrov wrote:
>> On 06/17/2009 07:39 PM, Andrew John Hughes wrote:
>>>> I opened a new bug report, with a patch and test case here:
>>>> https://bugs.openjdk.java.net/show_bug.cgi?id=100075
>>> I can confirm we still apply this fix to OpenJDK7 too, so it's needed
>>> for both repos.
>>> Any comments? Can we push this fix?
>> Thanks for the fix. Generally it looks good, however we currently 
>> don't use the awtFUnlock() method for some reason, and I think at some 
>> point the method will just be removed.
>> Instead I suggest calling the XFlush() just after the XBell() call. 
>> Similar approach is used across the XToolkit code, so that would look 
>> better at least for the matter of consistency. Can you update the 
>> patch please?
> Updated:
> http://cr.openjdk.java.net/~langel/6721086-jdk6-webrev-NEW/
> Please let me know if this is good to go.

Looks fine.



> Thanks,
> Lillian

More information about the awt-dev mailing list