<AWT Dev> Patch for review: TestDialogTypeAhead

Andrew John Hughes gnu_andrew at member.fsf.org
Mon Oct 12 10:27:24 PDT 2009

2009/9/23 Man Wong <mwong at redhat.com>:
> Hi,
> Webrev: http://icedtea.classpath.org/~mwong/webrevs/index.html
> Summary: This is about jtreg bug in openjdk7, TestDialogTypeAhead ({openjdkdir}/jdk/test/java/awt/KeyboardFocusManager/TypeAhead
>         /TestDialogTypeAhead.java). It relates to bug ID 6446952, which in the test itself includes a workaround and that causes it to fail in fedora
>         10/11. After removing the work around, as in my webrev, the test passes. Does the fix look ok to push to the awt forest? Any comments?
>         Thanks.
> Man Lung Wong


Can someone from the AWT team please respond on this?

The patch removes a hack used to workaround bug 6446952, which
(apparently) occurs sporadically on some Windows platforms.  According
to the bug report
(http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6446952), the bug
itself has been fixed in 'mustang b93', whatever that is, which
implies the hack is probably no longer needed even where 6446952 was
evidenced.  What we do know from our testing is that this hack causes
the test to fail consistently on GNU/Linux platforms, and removing it
causes it to succeed.

Does this patch look ok to push to the AWT forest?
Andrew :-)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK

PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint: F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8

More information about the awt-dev mailing list