<AWT Dev> [8] Please review fix for 7177144: [macosx] Drag and drop not working (regression in 7u6)

Sergey Bylokhov Sergey.Bylokhov at oracle.com
Fri Aug 10 06:11:50 PDT 2012

10.08.2012 16:26, Alexander Zuev wrote:
> Hello,
>   please review my fix for CR 7177144: [macosx] Drag and drop not 
> working (regression in 7u6)
>   I still tink we shouldn't move the instanceof check to the earlier 
> stage since this check may be costly
> so it should not be performed unless other possibilities are ruled out 
> by the less expensive checks.
At least one of them can be moved from coalesceMouseEvent to coalesceEvent

         if (e instanceof MouseEvent && !(e instanceof 
SunDropTargetEvent)) {


in cacheEQItem() it executes almost always. Why we should not cache 
these events? This fix affects all platforms it should?

> Bug description is: 
> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7177144
> Webrev can be found here: 
> http://cr.openjdk.java.net/~kizune/7177144/webrev.01
> With best regards,
> Alex

Best regards, Sergey.

More information about the awt-dev mailing list