<AWT Dev> [7u8] Review request for 7189350: Fix failed for CR 7162144
Sergey.Bylokhov at oracle.com
Tue Aug 21 02:24:19 PDT 2012
In this case this fix looks good.
20.08.2012 22:16, Anthony Petrov wrote
> We do not reset the status ourselves. The interrupted status has
> already been reset by code that invoked interrupted() and thrown the
> InterruptedException in the first place.
> There's nothing wrong with that, though, because we reset the
> doDispatch flag upon processing the exception. We now use this flag to
> indicate that event processing must be stopped.
> best regards,
> On 8/20/2012 8:01 PM, Sergey Bylokhov wrote:
>> Is it ok that we reset the interrupted status in the 251-253?
>> 20.08.2012 19:24, Anthony Petrov wrote:
>>> Please review a fix for
>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7189350 at:
>>> With this fix we resolve an issue originally described in 7162144 by
>>> properly handling thread interruption requests. We no longer
>>> override the Thread.interrupt() for the EDT, and hence don't clash
>>> with NetBeans using thread interruption for its own purposes.
>>> Note that there's still not a regression test since NetBeans' test
>>> is very heavy (over 100MB) and impractical for our purposes.
>>> However, the NetBeans team has tested a developer build with this
>>> fix and found no regressions.
>>> PS. We aren't yet sure if we want the same fix for JDK 8, hence we
>>> fix it for 7u8 first.
>>> best regards,
Best regards, Sergey.
More information about the awt-dev