<AWT Dev>  Review request for 7153339: InternalError when drawLine with Xor and Antialiasing
oleg.pekhovskiy at oracle.com
Thu Aug 23 16:37:38 PDT 2012
Hi Phil, Jim,
thank you for pointing out the testing work that should be performed.
I tested my fix with the following regression tests:
Plus I tested performance differences on:
Testing was done on Windows 7 & Ubuntu 12.04 LTS.
No differences were found.
I also asked Yuri Nesterenko to test all that stuff on Mac.
11.08.2012 3:10, Phil Race wrote:
> This looks OK to me but since this is a shared code change I have
> to ask what testing you've done ?
> Also why not provide a regression test ? The provided test was
> interactive but I think it can be automated.
> You need another review and I'd like Jim to take a look.
> On 8/10/2012 2:26 PM, Oleg Pekhovskiy wrote:
>> Please review the fix for CR:
>> XOR is not supported for D3D (see comments inside
>> D3DSurfaceData.validatePipe()) and
>> software rendering is used invalidating current D3DSurfaceData.
>> So we have situation when component's peer has invalid SurfaceData
>> and it's retrieved in
>> SunGraphics2D.revalidateAll() through SurfaceData.getReplacement()
>> without any check.
>> That's why I added validity check there.
More information about the awt-dev