<AWT Dev> Request review for 7129742 : Unable to view focus in Non-Editable TextArea
zhouyx at linux.vnet.ibm.com
Mon Feb 6 01:31:14 PST 2012
The testcase is added, the new link is
Please review and give your comments.
When writing the testcase, I found the application would not exit if
the caret is set visible. It is
caused by the timer thread controlling the blinking of the caret. So I set
the caret invisible when
disposing the TextArea.
More info: The patch is for bug 7129742,
On Mon, Jan 16, 2012 at 11:56 PM, Artem Ananiev <artem.ananiev at oracle.com>wrote:
> Hi, Sean,
> text components in XToolkit use Swing peers, so this change should better
> be reviewed on the swing-dev alias. To save everybody's time, I've asked
> Alex and Pavel from the Swing team (in CC) to take a look and they confirm
> the fix looks fine.
> Did you consider creating a new regression test for this fix? I'm not sure
> it's easy to detect if caret is visible in the text component or not,
> On 1/16/2012 7:08 AM, Sean Chou wrote:
>> Hi all,
>> I made a patch for bug 7129742,
>> The webrev link is : http://cr.openjdk.java.net/~**
>> The solution is very simple, just set the cursor visible.
>> Please have a look and give some comments. Thanks.
>> Best Regards,
>> Sean Chou
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the awt-dev