<AWT Dev> [7u10] Review request for 7124375: [macosx] Focus isn't transfered as expected between components

Anton V. Tarasov anton.tarasov at oracle.com
Tue Sep 11 02:14:46 PDT 2012

Looks fine to me.


On 10.09.2012 20:52, Leonid Romanov wrote:
> Hi,
> This is a back port of the fix that went into JDK 8.
> The main issue addressed by this fix is that information about current focused window and focus 
> owner isn't shared among LWKeyboardFocusManagerPeer instances. Also, while the current 
> KeyboardFocusManager code makes it look like each KeyboardFocusManager instance needs its own peer 
> instance, the reality is different because both WKeyboardFocusManagerPeer and XKeyboardManagerPeer 
> doesn't have non static fields. In other words, all the 
> WKeyboardFocusManagerPeer/XKeyboardManagerPeer fields are static. Therefore, there is no need in 
> in multiple peer instances, one singleton peer shared among all the KeyboardFocusManager instances 
> is enough. This fix addresses that issue as well by explicitly turning KeyboardManagerPeer 
> implementations into singletons for the sake of cleaner code.
> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7124375
> Webrev: http://cr.openjdk.java.net/~leonidr/7124375/webrev.01/ 
> <http://cr.openjdk.java.net/%7Eleonidr/7124375/webrev.01/>
> Thanks,
> Leonid.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20120911/1f559ccc/attachment.html 

More information about the awt-dev mailing list