<AWT Dev> [7u40] Review request for 8019628: [macosx] closed/java/awt/Modal/BlockedMouseInputTest/BlockedMouseInputTest.html failed since 7u40b30 on MacOS

Alexander Scherbatiy alexandr.scherbatiy at oracle.com
Fri Jul 5 06:47:51 PDT 2013


Could you review the fix for the regression in JDK 7u40:
bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8019628
webrev: http://cr.openjdk.java.net/~alexsch/8019628/webrev.00

Generated enter/exit mouse events have been changed to use the current 
mouse event id during the last merge in the JDK 7u40:
For example
          Point oldp = lastMouseEventPeer.windowToLocal(x, y, this);
-        postEvent(new MouseEvent(lastMouseEventPeer.getTarget(),
-                                  MouseEvent.MOUSE_EXITED,
-                                  when, modifiers,
-                                  oldp.x, oldp.y, screenX, screenY,
-                                  clickCount, popupTrigger, button));
+        Component target = lastMouseEventPeer.getTarget();
+        postMouseEnteredExitedEvent(target, id, when, modifiers, oldp,
+                screenX, screenY, clickCount, popupTrigger, button);

So the mouse enter/exit events are now can be lost and wrong events can 
be sent for the lastMouseEventPeer.
The fix adds the explicit mouse enter/exit events declaration back as it 
was before the merge.

There are 2 failed tests in the JDK 7u repository because of the 
regression so it is not necessary to write new one.


More information about the awt-dev mailing list