<AWT Dev> [8] Request for review: JDK-8020927 JLightweightFrame API should export layout properties change notifications

Anthony Petrov anthony.petrov at oracle.com
Fri Jul 19 06:43:47 PDT 2013

Hi Anton,

The fix looks good overall.

I'm just not sure about the exact symmetry between the setContent() 
method and the componentRemoved() listener wrt. the layoutSizeListener 
adding/removing. In theory, the setContent() may be called several times 
with different (or same) content objects. Similarly, the contentPane may 
in theory be added or removed manually several times (or even 
transferred between different JLFs).

Perhaps both adding and removing the layoutSizeListener should happen in 
componentAdded() and componentRemoved() correspondingly?

best regards,

On 07/19/2013 04:27 PM, Anton V. Tarasov wrote:
> Please, review a fix.
> jira: https://jbs.oracle.com/bugs/browse/JDK-8020927
> webrev: http://cr.openjdk.java.net/~ant/JDK-8020927/webrev.0
> Layout bounds notifications are added to internal JLightweightFrame API.
> (Just FYI, related fx changes are here:
> http://cr.openjdk.java.net/~ant/RT-30650/webrev.0)
> Thanks,
> Anton.

More information about the awt-dev mailing list