<AWT Dev>  Request for review: 8017189 [macosx] AWT program menu disabled on Mac
leonid.romanov at oracle.com
Mon Jul 22 12:32:37 PDT 2013
On Jul 22, 2013, at 6:02 PM, Sergey Bylokhov <Sergey.Bylokhov at oracle.com> wrote:
> Hi, Leonid.
> Is seems to me that this is another issue, and both jdk6jdk8 behave incorrectly.
> When the window with mainmenubar is disposed, menu should be removed, because it doesn't make sense in this case. So dispose of the window should be fixed.
> What do you think?
Well, I'd like us to stay consistent with JDK 6. However, if we decide to fix this issue in some other way, we need to be consistent with other possible cases, like setting frame's menu to null before showing a dialog, making frame invisible, and so on.
But as you've said, this issue is not related to 8017189, so let's go back to the fix for 8017189. I've got another question about it. When native window loses focus, we call -(void) deactivate method of CMenuBar class. At first, I thought that it basically removes all the menu items from the menu bar, but then I realized that it is not the case, because your fix depends on the fact that the window gaining focus inherits the menu bar from the window that just lost it. Now, consider step 4 of your scenario. Here, the dialog2 is the window that is loosing focus, and dialog1 is the window that is gaining it. As a result of dialog2 loosing focus, the current menu bar gets marked as not active (sActiveMenuBar in CMenuBar is set to false). When dialog1 gains focus, we do nothing with the current menu, because the opposite window (dialog2) doesn't formally have a menu (opposite->javaMenuBar is NULL). This means that dialog1 now has a menu that is formally inactive.
Since I don't really understand the purpose of -(void) deactivate method, I can't say whether the situation I've described above is problematic or not. What do you think?
> On 22.07.2013 16:57, Leonid Romanov wrote:
>> Here is a test case that, with your patch applied, works differently than JDK 6:
>> 1. Show JFrame with a menu
>> 2. Create a modal dialog with the frame as a parent
>> 3. Dispose the frame
>> 4. Make dialog visible
>> With JDK 6, the dialog's menu will be disabled. With JDK 8, it will be enabled. So, formally, we've got a regression. I'm not sure whether it is worth fixing, because it looks like a corner case, but still.
>> On Jul 19, 2013, at 10:15 PM, Sergey Bylokhov <Sergey.Bylokhov at oracle.com> wrote:
>>> Please review the fix for jdk 8 and 7u40.
>>> The fix for JDK-8010906 don't take into account situation then first parent has no menu bar, but the second has.
>>> So it introduce the next scenario:
>>> #1. Open the window with File menu.
>>> #2. Open modal dialog1 =>File menu is disabled
>>> #3. Open modal dialog2 =>File menu disappears
>>> #4. Close dialog two
>>> #5. Close dialog one. File menu reappears, but File still disabled
>>> The steps #3. occurred, because CMenuBar.activate resets the current menubar if a passed javaMenuBar is null.
>>> The steps #5. occurred, because at step #3 we do not remove our nsmenu from the deleted NSMenuItem, when the appropriate NSMenuItem removed from mainMenu. So at step #5 we got a situation, when our nsmenu was added to the two different nsmenuitems: old(disabled) and new(enabled).
>>> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8017189
>>> Webrev can be found at: http://cr.openjdk.java.net/~serb/8017189/webrev.00
>>> Best regards, Sergey.
> Best regards, Sergey.
More information about the awt-dev