<AWT Dev> <Swing Dev> [PATCH] 7168064: SwingUtilities.sharedOwnerFrame multiplies window close event
anthony.petrov at oracle.com
Tue May 28 08:13:34 PDT 2013
I filed a bug for this issue:
and published your patch as a webrev at:
Please note that in JDK we use 4 spaces (and not TABs characters) for
indenting lines. Could you please reformat your test and also use proper
indentation for the two lines in Window.java that you're changing? Also,
the copyright header in the test should be from the year 2013, not 2006.
:) Please fix this and resend your patch.
Other than these minor suggestions, the proposed fix looks good to me.
Note that we need to get at least one more review from a reviewer on
this mailing list before we can push this fix to a repository.
On 05/28/2013 03:35 PM, Jose Luis Martin wrote:
> Hi Anthony,
> Please, review the patch and test.
> Best Regards,
> -- Jose Luis Martin.
> El mié, 22-05-2013 a las 13:52 +0400, Anthony Petrov escribió:
>> If you and other AWT folks agree with that, could you prepare a patch
>> for this change and a jtreg-based regression test (it should be put
>> somewhere in test/java/awt/Window/, I think)?
>> best regards,
More information about the awt-dev