<AWT Dev> <Swing Dev> [PATCH] 7168064: SwingUtilities.sharedOwnerFrame multiplies window close event
Jose Luis Martin
jlm at joseluismartin.info
Tue May 28 10:03:57 PDT 2013
Just fixed. Thanks again.
-- Jose Luis Martin.
On 28-05-2013 a las 19:13 +0400, Anthony Petrov wrote
> Hi Jose,
> I filed a bug for this issue:
> and published your patch as a webrev at:
> Please note that in JDK we use 4 spaces (and not TABs characters) for
> indenting lines. Could you please reformat your test and also use proper
> indentation for the two lines in Window.java that you're changing? Also,
> the copyright header in the test should be from the year 2013, not 2006.
> :) Please fix this and resend your patch.
> Other than these minor suggestions, the proposed fix looks good to me.
> Note that we need to get at least one more review from a reviewer on
> this mailing list before we can push this fix to a repository.
> best regards,
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 7070 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20130528/565b5b04/jdk8_8015500.diff
More information about the awt-dev