<AWT Dev> Request for review: 7006052: awt_InputMethod.c cleanup is needed

Naoto Sato naoto.sato at oracle.com
Fri May 31 10:10:16 PDT 2013

Hi Anthony,

Thank you for the review. I initially thought I would remove XAWT_HACK 
from makefiles, but noticed XAWT was still there as well. So I just left 
the compiler flag as it was. I think it's up to AWT team to remove those 
flags, as I am not sure the original intention of XAWT_HACK ifdefs.


On 5/31/13 4:19 AM, Anthony Petrov wrote:
> Hi Naoto,
> I'm not an expert in this code, but the changes look good to me.
> Should we also remove the definition of the XAWT_HACK symbol from our
> makefiles if we don't use it anymore (this needs to be checked though)?
> --
> best regards,
> Anthony
> On 05/30/2013 03:31 AM, Naoto Sato wrote:
>> Hello,
>> Please review the fix for the following bug:
>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7006052
>> Webrev for the fix is located here, which simply removes "XAWT_HACK"
>> ifdefs ("XAWT" ifdefs are already removed):
>> http://cr.openjdk.java.net/~naoto/7006052/webrev.00/
>> Naoto

More information about the awt-dev mailing list