<AWT Dev>  Review request for 7160604: Using non-opaque windows - popups are initially not painted correctly
Sergey.Bylokhov at oracle.com
Wed Nov 20 03:14:59 PST 2013
Looks like now getPopup method should be renamed, because it returns
On 20.11.2013 15:06, Oleg Pekhovskiy wrote:
> Hi all,
> please review the fix
> For now popup menu is painted correctly, so the fix applies to
> drop-down list of combo-box only.
> BasicComboPopup class implements drop-down list.
> BasicComboPopup.isVisible() checks whether BasicComboPopup.popup field
> is not null. When the drop-down list is about to show and the
> following call-chain occurs: BasicComboPopup.togglePopup() -> show()
> -> setVisible(true) -> getPopup()
> newPopup.show() method is called before BasicComboPopup.popup field is
> updated. Thus when painting occurs for the first time (synchronously,
> inside newPopup.show()), BasicComboPopup.isVisible() returns false and
> JComponent.paintChildren() skips drawing of BasicComboPopup.
> So the fix makes BasicComboPopup.popup field being updated before call
> of Popup.show(). Moreover setting of BasicComboPopup.popup field was
> moved inside BasicComboPopup.getPopup() method as the same thing
> happened after each call of this method.
Best regards, Sergey.
More information about the awt-dev