<AWT Dev> RFR 8028019 Doclint cleanup of java.awt

roger riggs roger.riggs at oracle.com
Wed Nov 27 08:15:08 PST 2013

Hi Yuri,

I don't see a spacing difference between <br> and no markup.
<br> is supposed only to terminate the line, not add any spacing
and I did not see any difference in an example I tried.
Perhaps you would point me to a specific example.

The formatting should be handled by the stylesheets and adding extra
markup to affect the presentation is not the best approach.

Thanks, Roger

On 11/27/2013 4:19 AM, Yuri Nesterenko wrote:
> Hi Roger,
> note that when you just delete a standalone "p" tag,
> the lines around it will (well, may) become closer
> to each other, as close as regular text lines.
> It was apparently not an intention of original author
> of a document.
> Sergey Lugovoy in similar cases does often add "br"
> instead of "p": it keeps tidy happy (and I believe, doclint too)
> and doesn't change a document visually.
> Note that with JDK-8025235 some 2D stuff was fixed
> (see the bug for a list)(the fix is still in team).
> I promise to review next version of your fix as soon as it
> will be possible. We have too many of doc fixes stalling.
> Thanks,
> -yan
> On 11/10/2013 01:13 AM, roger riggs wrote:
>> Hi,
>> I updated the webrev to taking account doclint errors already fixed by
>> 8026021 <https://bugs.openjdk.java.net/browse/JDK-8026021> More fix of
>> javadoc errors and warnings reported by doclint.
>> Please review:
>> http://cr.openjdk.java.net/~rriggs/webrev-lint-awt-8028019/
>> If these patches are still useful please let me know.
>> Roger
>> On 11/7/2013 5:18 PM, roger riggs wrote:
>>> This changeset addresses the warnings and errors of doclint and
>>> improves the quality of the generated html.
>>> No spec or implementation is changed by this changeset.
>>> The changes address issues including html syntax, accessibility issues,
>>> and improper html tag use. Refer to the error log attached to the bug
>>> report [1] for details.
>>> The changes are concisely found in the jdk.patch file.
>>> Please review:
>>> http://cr.openjdk.java.net/~rriggs/webrev-lint-awt-8028019/
>>> Thanks, Roger
>>> [1] https://bugs.openjdk.java.net/browse/JDK-8028019

More information about the awt-dev mailing list