<AWT Dev> [8] Review request for 7092283 Property Window.locationByPlatform is not cleared by calling setVisible(false)

Anthony Petrov anthony.petrov at oracle.com
Wed Sep 25 06:37:35 PDT 2013

Hi Alexander,

The setter and getter for this property access the boolean flag under 
the tree lock. I suppose this was the locking design for this field. So 
you should reset it under this lock, too. You could also go ahead and 
add proper locking to other methods that access it (e.g. show(), etc.)

Please run Window, Frame, and Dialog automatic regression tests (open 
and closed) to ensure no regressions after this change.

best regards,

On 09/25/2013 04:50 PM, Alexander Scherbatiy wrote:
> Hello,
> Could you review the fix:
>    bug: https://bugs.openjdk.java.net/browse/JDK-7092283
>    webrev: http://cr.openjdk.java.net/~alexsch/7092283/webrev.00
>    The Window.hide() method does not clear the locationByPlatform property.
> Thanks,
> Alexandr.

More information about the awt-dev mailing list