<AWT Dev> Review request for JDK-8038631: Create wrapper for awt.Robot with additional functionality

Petr Pchelko petr.pchelko at oracle.com
Fri Apr 4 14:17:29 UTC 2014

Hello, Dmitry.

> ExtendedRobot is a wrapper around java.awt.Robot that provides some convenience methods.
> It contains methods that are ought to be moved to {@link java.awt.Robot} class

This is not true. The ExtendedRobot is not a wrapper but a subclass. Also the first mention of "java.awt.Robot" lacks the @link.

> ... and sets delay value depends on property value. If property was not set default value of 500 ms is used.

This is not an English phrase to my ear... May be something like: "... and sets the delay value equal to the property value. 
If the property was not set 500 milliseconds default value is used."? But I'm also not a native speaker and I may be wrong here)

Also just a suggestion: 
The glide implementation is not optimal - when int parameters are passed you are creating Point objects and then converting 
them back to int. It's better to make int-base method main and reuse it in the Point-based.

With best regards. Petr.

On 04.04.2014, at 17:49, Dmitriy Ermashov <dmitriy.ermashov at oracle.com> wrote:

> Hi,
> Please, review the changeset for:
> https://bugs.openjdk.java.net/browse/JDK-8038631
> Webrev is here:
> http://cr.openjdk.java.net/~yan/8038631/webrev.04/
> Last changes consist of:
> 1. Removed unnecessary System.out calls.
> 2. System.getProperty wrapped in doPrivileged block.
> 3. Javadoc improvement, added info about system property "java.awt.robotdelay"
> 4. Added modifier final for property syncDelay.
> -- 
> Thanks,
> Dima

More information about the awt-dev mailing list