<AWT Dev>  Review Request: 8039567 Duplicated code in DataTransferer
petr.pchelko at oracle.com
Thu Apr 17 09:00:15 UTC 2014
Could I get a second review on this.
With best regards. Petr.
On 09.04.2014, at 18:57, Alexander Zvegintsev <alexander.zvegintsev at oracle.com> wrote:
> Hi Petr,
> the fix looks good to me.
> On 04/09/2014 06:27 PM, Petr Pchelko wrote:
>> Hello AWT team.
>> Please review a simple cleanup fix for the issue:
>> The fix is available here:
>> 1. The getBestCharsetForTextFormat is duplicated 3 times in the code.
>> 2. Caching of the default Charset in DataTransferer does not make sense as it's already cached in the Charset class itself.
>> Adding more references to the nio.Charset is not a problem since it's used in this class anyway and we cannot break this
>> With best regards. Petr.
More information about the awt-dev