<AWT Dev> Review request for JDK-8039279: Move first batch of functional tests to openjdk repository

Alexander Scherbatiy alexandr.scherbatiy at oracle.com
Mon Apr 21 10:06:46 UTC 2014

  The fix looks good for me.

  If it is unlikely to use sun.awt.* classes to check the OS version, 
may be it would be better to add the OS version check method to the 


On 4/17/2014 1:22 PM, Dmitriy Ermashov wrote:
> Hi,
> Please, review the changeset for:
> https://bugs.openjdk.java.net/browse/JDK-8039279
> Webrev is here:
> http://cr.openjdk.java.net/~yan/8039279/webrev.03/
> Changelist:
> 1. Removed internal API usage (sun.awt.*)
> 2. Removed Asserts library dependency from all tests except of 
> ModifierRobotKeyTest (too much usage of asserts in it).
> 3. Improved thread synchronization in ComponentPreferredSize, 
> ChangeGridSize, ModifierRobotKeyTest, LockingKeyStateTest
> 4. Added disposing frame at the end of each test.
> Test runs on the following platforms seems stable:
> Windows 7 x64, Intel graphical card
> Ubuntu Linux 12.04 x64, Intel graphical card
> OS X 10.8.5 x64, NVIDIA GeForce 9400
> Ubuntu 10.04 ARMv7
> --Dima

More information about the awt-dev mailing list