<AWT Dev>  Review request for 8040279 [macosx] Do not use the base image in the MultiResolutionBufferedImage constructor
petr.pchelko at oracle.com
Mon Apr 21 12:45:12 UTC 2014
The fix looks good.
With best regards. Petr.
On 21.04.2014, at 16:43, Alexander Scherbatiy <alexandr.scherbatiy at oracle.com> wrote:
> Could you review the updated fix:
> The createBufferedImage method is renamed to createImage in the CImage class.
> On 4/21/2014 2:36 PM, Petr Pchelko wrote:
>> Hello, Alexander.
>> Just one minor comment: In CImage createBufferedImage method does not create a BufferredImage any more, so it worths renaming.
>> With best regards. Petr.
>> On 15.04.2014, at 18:36, Alexander Scherbatiy <alexandr.scherbatiy at oracle.com> wrote:
>>> Could you review the fix:
>>> bug: https://bugs.openjdk.java.net/browse/JDK-8040279
>>> webrev: http://cr.openjdk.java.net/~alexsch/8040279/webrev.00
>>> MultiResolutionBufferedImage extends BufferedImage. In this case it needs to use the base image to write it to the BufferedImage.
>>> The fix renames MultiResolutionBufferedImage to MultiResolutionCahcedImage and does not use the BufferedImage as the super class.
>>> The base image is created and cached by demand.
>>> CImage now always returns MultiResolutionCahcedImage. All requested resolution variants are scaled by NSImage.
More information about the awt-dev