<AWT Dev>  Review Request for 8041592: [TEST_BUG] Move 42 AWT hw/lw mixing tests to jdk
petr.pchelko at oracle.com
Tue Apr 29 09:30:25 UTC 2014
I didn't look at every line, but generally the fix looks good to me.
With best regards. Petr.
On 29.04.2014, at 12:42, Yuri Nesterenko <yuri.nesterenko at oracle.com> wrote:
> Could anyone please look at this, too: we need 2 reviewers to go on.
> And thank you Anthony!
> On 04/25/2014 03:57 PM, Anthony Petrov wrote:
>> Hi Yuri,
>> Great to see more tests covering the HW/LW Mixing functionality coming
>> in! I briefly skimmed through the patch, and it looks good to me.
>> best regards,
>> On 4/24/2014 1:26 PM, Yuri Nesterenko wrote:
>>> please review this change for
>>> Webrev is in:
>>> Here's an excerpt from the bug Description:
>>> There are 42 automatic functional tests verifying various aspects of
>>> HW/LW mixing in AWT. We will move them to a separate directory
>>> Note that:
>>> (1) we decided to make only small changes to the tests as it is just
>>> some 5% of our task at hand;
>>> (2) tests are written in someway different styles;
>>> (3) most of them extend some basic class (included in the
>>> same directory);
>>> (4) they use an utility class (included) someway duplicating new
>>> functionality of ExtendedRobot. However we left this part intact to
>>> avoid unnecessary refactoring;
>>> (5) the tests seems stable enough. They were run on 3 platforms
>>> continuously many times together demonstrating exactly the same output.
>>> (6) Of the 42 in total, 3 fail on OS X (2 of them also on Linux and
>>> Windows) because of the open product bugs.
More information about the awt-dev