<AWT Dev> JDK 9 RFR of JDK-8039109 : Fix unchecked and raw lint warnings in java.awt
petr.pchelko at oracle.com
Wed Apr 30 08:40:12 UTC 2014
The new version looks good to me.
Please note that I'm not an expert in java.awt.image.* code,
so I'm speaking mostly for the AWT and DnD part.
With best regards. Petr.
On 30.04.2014, at 12:17, Joe Darcy <joe.darcy at oracle.com> wrote:
> Hi Petr,
> Updated webrev uploaded:
> On 04/29/2014 11:21 PM, Petr Pchelko wrote:
>> Hello, Joe.
>> In RenderableImageOp.getRenderableSources only RenderableImage instances are added to the Vector.
>> So the method could return Vector<RenderableImage> to avoid the cast in getSources() method.
>> With best regards. Petr.
>> On 30.04.2014, at 0:26, Joe Darcy <joe.darcy at oracle.com> wrote:
>>> Now that Henry's fixes of raw and unchecked warnings in sun.awt has been pushed, please review this change to fix issues in java.awt:
>>> JDK-8039109 : Fix unchecked and raw lint warnings in java.awt
>>> Full patch below. A few points of interest in the patch:
>>> * There is a change to the signature of a public method in java.awt.image.renderable.ParameterBlock.java (I believe that is the only such change in this patch; internally, a ccc request will be filed for this part of the fix.)
>>> * In my estimation the changes in java.awt.GraphicsEnvironment.java are a better use of generics and reflection.
More information about the awt-dev