<AWT Dev> [9] Review Request: 8042219 [macosx] LWComponentPeer should not reference classes from sun.lwawt.macosx

Sergey Bylokhov Sergey.Bylokhov at oracle.com
Wed Apr 30 13:58:21 UTC 2014

Hi, Petr.
A few comments:

1)     if (fDropTarget != null)
         1065 System.err.println("CComponent.addDropTarget(): current 
drop target is non-null.");
  Should we throw an exception instead or dispose the previous drop target?
2) We can create/dispose DT on any thread?
3) {@inheritDoc} is obvious if no additional information is added.

On 4/30/14 5:33 PM, Petr Pchelko wrote:
> Hello, AWT Team.
> Please review a simple cleanup fix for the issue:
> https://bugs.openjdk.java.net/browse/JDK-8042219
> The fix is available here:
> http://cr.openjdk.java.net/~pchelko/9/8042219/webrev/
> We should not reference macosx classes in lwawt package. I've also cleaned up CDropTarget class a bit.
> Thank you.
> With best regards. Petr.

Best regards, Sergey.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20140430/73819639/attachment.html>

More information about the awt-dev mailing list