<AWT Dev> RFR for JDK-8028711: TEST_BUG: Tests should pass through VM options: corelibs tests

Alan Bateman Alan.Bateman at oracle.com
Wed Feb 12 10:35:17 PST 2014

On 12/02/2014 12:59, michael cui wrote:
> On 02/10/2014 05:36 PM, Alan Bateman wrote:
>> A minor comment on test/java/net/URLPermission/nstest/lookup.sh is 
>> that the resulting line length is 182 characters and this will likely 
>> be annoying for future side-by-side views. So I think I'd split this 
>> while you are there. 
> Please review the updated version at 
> http://cr.openjdk.java.net/~tyan/michael/JDK-8028711/webrev.04/ 
> <http://cr.openjdk.java.net/%7Etyan/michael/JDK-8028711/webrev.04/>
> Changes includes :
> 1. split line if it longer than 80 characters.
> 2. merge the fix of JDK-8033897 
> <https://bugs.openjdk.java.net/browse/JDK-8033897>
> 3. add few missed scripts.
> If no further changes need to be made, I would like to find sponsor to 
> push this fix.
The changes look okay to me. I see you decided to ignore the javac 
usages but that is okay and can be done another time.

Also thanks for fixing lookup.sh. I don't personally mind lines > 80 but 
that one was >180 which make it difficult to look at side-by-side changes.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20140212/9716a028/attachment.html 

More information about the awt-dev mailing list