<AWT Dev> [9] Review Request for 8049617: move awt automated tests from AWT_Modality to OpenJDK repository - part 3

Petr Pchelko petr.pchelko at oracle.com
Mon Jul 21 07:01:06 UTC 2014

Hello, Alexander.

In doTest you are doing closeAll in the end. But if the test is failed and any assert throws an exception, closeAll will not be called and a frame could be left on the screen. I think it's better to call closeAll from a finally block.

With best regards. Petr.

On 18 июля 2014 г., at 16:59, alexander stepanov <alexander.v.stepanov at oracle.com> wrote:

> Hello,
> Could you please review the fix for
> https://bugs.openjdk.java.net/browse/JDK-8049617
> webrev:
> http://cr.openjdk.java.net/~avstepan/8049617/
> This is the next portion of functional AWT tests prepared for migration to OpenJDK repository.
> The tests were checked on Ubuntu 14.04 Linux, Solaris 11, Mac OS X 10.8.5 and Windows 7.
> Thanks,
> Alexander

More information about the awt-dev mailing list