<AWT Dev> [9] Review Request: 8037485 Refactor java.awt.datatransfer to eliminate dependency on AWT

Mandy Chung mandy.chung at oracle.com
Wed Jul 23 15:04:09 UTC 2014

On 7/23/2014 6:53 AM, Petr Pchelko wrote:
> Hello, Alan.
>> I'm skimmed over the updated webrev, it mostly looks good except for 
>> getFlavorMap where it doesn't set map, I assume you meant to do this:
>> if (map == null)
>>     flavorMap = map = supplier.get();
> Thank you! Updated the fix: 
> http://cr.openjdk.java.net/~pchelko/9/8037485/webrev.03/ 
> <http://cr.openjdk.java.net/%7Epchelko/9/8037485/webrev.03/>

I skimmed through the webrev and looks good.  It looks like that you 
have cleanly removed the dependency.  You can run jdk9/bin/jdeps [1] on 
the java.awt.datatransfer.** and its implementation classes to double 
check if there is no dependency to the desktop classes.

Minor comments I spotted:


line 225 and 238 look like debugging statement to be removed.

    line 544, 549 - some raw types and you may want to check if there are others.

[1] http://docs.oracle.com/javase/8/docs/technotes/tools/unix/jdeps.html

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20140723/f5ad0fcf/attachment.html>

More information about the awt-dev mailing list