<AWT Dev> [9] Review Request: 8051449 Incorrect parsing of the default flavor mapping

Petr Pchelko petr.pchelko at oracle.com
Mon Jul 28 12:20:25 UTC 2014

Hello, Sergey.

>  Probably we can call it from java.util.Properties directly?

It's private inside Properties class. We could've used an Accessor in sun.misc, but this would add some issues for modules.
Reflection is also a possibility, but again, it's not very good for modules. Here I'm just reverting a piece of my previous fix and I
think it's the safest solution.

With best regards. Petr. 

On 28 июля 2014 г., at 16:14, Sergey Bylokhov <Sergey.Bylokhov at oracle.com> wrote:

> Hi, Petr.
> The previous version has a note that it was copied from the java.util.Properties. Probably we can call it from java.util.Properties directly?
> On 7/28/14 3:35 PM, Petr Pchelko wrote:
>> Hello, AWT Team.
>> Please review an updated version of this fix:
>> http://cr.openjdk.java.net/~pchelko/9/8051449/webrev.01/
>> I've changed the package name for a flavormap.properties file, because it needs to go to the
>> datatransfer module and in a parallel review we've decided to change it's package name.
>> All the rest is the same as in the previous version.
>> With best regards. Petr.
>> On 22 июля 2014 г., at 15:50, Petr Pchelko <petr.pchelko at oracle.com> wrote:
>>> Hello, AWT Team.
>>> Please review the fix for the issue:
>>> https://bugs.openjdk.java.net/browse/JDK-8051449
>>> The fix is available at:
>>> http://cr.openjdk.java.net/~pchelko/9/8051449/webrev/webrev/
>>> This is a regression of one of my recent fixes where I've got a bit too brave with a clenup.
>>> Here I've returning back the loadConvert function which translates escaped characters in
>>> a properties file to their actual ASCII representation.
>>> Thank you.
>>> With best regards. Petr.
> -- 
> Best regards, Sergey.

More information about the awt-dev mailing list