<AWT Dev>  Review request for 8043869 [macosx] java -splash does not honor @2x hi dpi notation for retina support
petr.pchelko at oracle.com
Tue Jun 17 12:22:34 UTC 2014
CCed Kumar as I believe he's the owner of the launcher code.
1. In splashscreen_sys.m you autorelease the fileName. But I do not see where the autoreleasepool is set up.
Wouldn't it be better to set up an autoreleasepool in this method explicitly?
2. In java.c:1859 DoSplashSetFileJarName sets the name of the file which was used for a splash. It can be
retrieved via public API SplashScreen.getImageURL. Is it correct to always set the file_name disregards the real
name we've used?
With best regards. Petr.
On 17 июня 2014 г., at 15:36, Alexander Scherbatiy <alexandr.scherbatiy at oracle.com> wrote:
> Could you review the fix:
> bug: https://bugs.openjdk.java.net/browse/JDK-8043869
> webrev: http://cr.openjdk.java.net/~alexsch/8043869/webrev.00
> The scaleFactor field is added to the Splash struct.
> The SplahsScreen class scales the graphics and the size according to the scale factor.
> The native system tries to load high resolution splash image on HiDPI display.
More information about the awt-dev