<AWT Dev>  Review Request for 8044429: move awt automated tests for AWT_Modality to OpenJDK repository
petr.pchelko at oracle.com
Wed Jun 18 15:18:45 UTC 2014
I didn't look at every line, but overall the fix looks fine to me.
With best regards. Petr.
On 18 июня 2014 г., at 19:14, alexander stepanov <alexander.v.stepanov at oracle.com> wrote:
> Hello Petr,
> Thank you for the note; fixed. Please see the updated webrev:
> On 18.06.2014 17:57, Petr Pchelko wrote:
>> Hello, Alexander.
>> In ExcludeDialogTest and ExcludeFrameTest you are emulating key type manually while ExtendedRobot can do that.
>> Same in TestWindow, TestFrame and TestDialog : 206 - You are manually emulating the click while ExtendedRobot provides this feature.
>> typeTab method duplicates functionality in ExtendedRobot.
>> With best regards. Petr.
>> On 18 июня 2014 г., at 16:35, alexander stepanov <alexander.v.stepanov at oracle.com> wrote:
>>> Could you please review the webrev:
>>> This is the 1st portion of functional AWT modality tests prepared for migration to OpenJDK repository in accordance with
>>> Some helper classes were moved too.
>>> The tests were checked on Ubuntu 14.04, Solaris 11, and Windows 7.
>>> At the moment the tests are failing on Mac OS X due to
More information about the awt-dev