<AWT Dev>  Review request for 8036598 [macosx] Create AquaIcons from image representations
petr.pchelko at oracle.com
Tue Mar 4 13:55:47 UTC 2014
I've been also looking around this code and I have a related question:
when we call getThisApplicationsIcon we are drawing the Dock icon on top of a multi-resolution background image.
However as I see, the dock icon image created with getThisApplicationsIcon and getGenericJavaIcon is not a
multi-resolution image and the requested size we pass in is ignored. Does it worth updating too, so that we could receive
the dock icon as a multi-resolution image also and then choose the representation which fits kAlertSubIconSize best to avoid
too big downscaling?
With best regards. Petr.
On 04.03.2014, at 17:32, Alexander Scherbatiy <alexandr.scherbatiy at oracle.com> wrote:
> Could you review the fix:
> bug: https://bugs.openjdk.java.net/browse/JDK-8036598
> webrev: http://cr.openjdk.java.net/~alexsch/8036598/webrev.00
> The fix creates an AquaIcon based on resolution variants.
> It becomes possible after the fix 8033534 where CImage returns
> a MultiResolution image based on NSImage representations.
More information about the awt-dev