<AWT Dev>  Review request for 8031471: Test closed/java/awt/dnd/FileDialogDropTargetTest/FileDialogDropTargetTest.java fails on Solaris zones virtual hosts
anthony.petrov at oracle.com
Tue May 27 11:24:01 UTC 2014
The changes look reasonable. +1.
Also, I'd appreciate if you could add the evaluation from your email to
the bug report itself.
On 5/27/2014 2:43 PM, Alexander Zvegintsev wrote:
> please review the fix:
> This fix also fixes 7100524  and 7054476  as well.
> This issue is related to the X error handling code: when we setting a
> synthetic error handler with WITH_XERROR_HANDLER()
> we do not wait for processing XErrorEvents for previous xlib calls which
> wasn't dispatched yet, so we can catch a wrong one.
> This fix adds a XSync() call. (like we do in the native
> WITH_XERROR_HANDLER macro in awt_util.h).
> RESTORE_XERROR_HANDLER(boolean doXSync) was called from native
> previously, but it was reverted back to use native xerror
> handler in 8025775  and is no longer needed.
>  https://bugs.openjdk.java.net/browse/JDK-7100524
>  https://bugs.openjdk.java.net/browse/JDK-7054476
>  https://bugs.openjdk.java.net/browse/JDK-8025775
More information about the awt-dev