<AWT Dev> Review request for 8145116: [TEST_BUG] Incorrect binary comparison in java/awt/event/KeyEvent/ExtendedModifiersTest/ExtendedModifiersTest.java

Ambarish Rapte ambarish.rapte at oracle.com
Thu Dec 10 15:31:06 UTC 2015


                Please review the fix patch for JDK9,

                Bug: https://bugs.openjdk.java.net/browse/JDK-8145116

                Webrev: http://cr.openjdk.java.net/~arapte/8145116/webrev.00/




This is a test code issue.

The binary comparison for validating the result was incorrect.

The test would PASS even for wrong inputs. 

Please refer to the bug description for how to provide wrong inputs.



Fixed the binary comparison.

Please compare line number 177 from left with line 185 on right.

Remaining changes are related to coding guidelines, robot synchronization.





-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20151210/c4d01c3e/attachment.html>

More information about the awt-dev mailing list