<AWT Dev> <Awt Dev>  Review Request for 8085895: The Textfield can't be shown after clicking "Show Textfield" button.
Sergey.Bylokhov at oracle.com
Wed Jun 10 15:09:12 UTC 2015
The fix looks fine.
On 10.06.15 15:19, Semyon Sadetsky wrote:
> Hi Sergey,
> Right. I introduced an exit condition:
> On 6/9/2015 9:13 PM, Sergey Bylokhov wrote:
>> Hi, Semyon.
>> The fix looks fine, but I worry about possible infinite loops, since
>> we have a loop here peer->componet->peer. Please check the next use case:
>> Will it works?
>> On 09.06.15 19:43, Semyon Sadetsky wrote:
>>> Please review fix for JDK9:
>>> bug: https://bugs.openjdk.java.net/browse/JDK-8085895
>>> webrev: http://cr.openjdk.java.net/~ssadetsky/8085895/webrev.00/
>>> In 8074028 overridden getPeer() was simply removed in XWindows peers
>>> of TextField and TextArea but that was not enough to preserve the
>>> components functionality.
>>> In the new design Component.getPeer() doesn't exist anymore. To
>>> restore the previous logic completely it requires to override in the
>>> peer delegate component all the Component methods those used
>>> getPeer() before. But I think that would be a bad piece of code. I
>>> propose more short fix that was tested to be working using jtreg
>>> TextFiled/* and TextArea/* tests.
>> Best regards, Sergey.
Best regards, Sergey.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the awt-dev