<AWT Dev> [9] Review Request: 8079965 Stop ignoring warnings for libawt_lwawt

Sergey Bylokhov Sergey.Bylokhov at oracle.com
Mon Sep 14 14:06:42 UTC 2015

Please review the fix for jdk9.

In the fix I remove WARNINGS_AS_ERRORS_clang option from the 
libawt_lwawt library, and fix some of the issues:

- jlong_md.h:69:9: warning: 'ptr_to_jlong' macro redefined. This is 
because the "jni_util.h" and 
"JavaNativeFoundation.framework/Headers/JNFJNI.h" both define this 
macro. I cleared our headers to eliminate this warning.

- PrinterView.m:207:21: warning: implicit conversion from enumeration 
type 'NSPaperOrientation' (aka 'enum NSPaperOrientation') to different 
enumeration type 'NSPrintingOrientation'. The problem is that the Apple 
changed the returned type of [NSPrintInfo orientation] from 
NSPrintingOrientation to NSPaperOrientation. Note that the 
NSPaperOrientation is available since OSX 10.9, which means that this 
change break the build on 10.8. Is it acceptable or should I suppress 
this warning? [1]

- CGraphicsDevice.m:336:41: warning: comparison between pointer and 
integer ('void *' and 'jint' (aka 'int')) if ([screenID pointerValue] == 
displayID). I have changed the type from pointerValue to unsignedIntValue.

Also I added "enum-conversion" to the DISABLED_WARNINGS_clang to 
suppress some warnings to fix them later, because it should be 
investigated how to fix it properly (ImageSurfaceData.m:1090:93: 
warning: implicit conversion from enumeration type 'CGImageAlphaInfo' 
(aka 'enum CGImageAlphaInfo') to different enumeration type 'CGBitmapInfo')

After the fix all new warnings will break the build. The currently 
disabled warnings will be fixed as part of JDK-8074825 [2].

jprt build passed.

[2] https://bugs.openjdk.java.net/browse/JDK-8074825

Bug: https://bugs.openjdk.java.net/browse/JDK-8079965
Webrev: http://cr.openjdk.java.net/~serb/8079965/webrev.01

Best regards, Sergey.

More information about the awt-dev mailing list