<AWT Dev> <Awt Dev>  Review Request for 8079595: Resizing dialog which is JWindow parent makes JVM crash
semyon.sadetsky at oracle.com
Thu Sep 17 05:33:29 UTC 2015
On 9/16/2015 5:54 PM, Sergey Bylokhov wrote:
> 16.09.2015 17:07, Semyon Sadetsky wrote:
>> Other scenarios do not cause conflicts.
> Or we cannot reproduce it right now?
and for all these years...
>> Direct call to DefWindowProc is much faster it's better to preserve it.
> Is the performance important in this case? This methods is used for
> IME only? The unified implementation has a benefit that probability to
> find a bug in the code is higher.
Those events come on each window activation regardless using IME. We
have a chance to get a performance regression in that case.
>> On 9/16/2015 4:52 PM, Sergey Bylokhov wrote:
>>> Why we cannot always send a messages via SendMessage?
>>> Can you add a comment to the changed lines to clarify the fix. It is
>>> unclear for example why IsContainer() is used.
>>> 16.09.2015 15:36, Semyon Sadetsky wrote:
>>>> Please review fix for JDK9:
>>>> bug: https://bugs.openjdk.java.net/browse/JDK-8079595
>>>> webrev: http://cr.openjdk.java.net/~ssadetsky/8079595/webrev.00/
>>>> Direct call to DefWindowProc() of the child window's owner causes a
>>>> conflict. Using SendMessage() eliminates it.
More information about the awt-dev