<AWT Dev> Review Request for JDK-8040322 : TextArea.replaceRange() and insert() are broken with setText(null)
ambarish.rapte at oracle.com
Mon Sep 21 09:38:46 UTC 2015
The previous mail for review of this issue JDK-8040322,
is filtered with another issue & issues are merged.
So I am writing a new mail to continue the review on separate thread.
Thanks for the review. Updated the patch according to your review comments.
Please take a look.
Please review this patch at
Webrev : http://cr.openjdk.java.net/~psadhukhan/ambarish/8040322/webrev.01/
Below is history from previous mail discussion,
A few comments.
- The fix changed the order of methods calls. Note that if the user overrides the "appendText" then it is called after an "append".
- It seems that before the fix we always tried to use the empty string for a null text(we replace null to "" in the constructor and setText), the new code should maintain the same assumption.
On 18.09.15 14:36, Ambarish Rapte wrote:
> Please review the following fix for jdk9.
> / TextArea.setText(null)/ does not set TextArea text to
> /null/ when called after
> /TextArea.replaceRange(), TextArea.insert(), TextArea.append()./
> Variable "/text/" was not correctly updated in
> /TextArea.replaceRange(), TextArea.insert(), TextArea.append()/ in
> awt / TextArea.java
> Update the variable "text" correctly with the calls
> /TextArea.replaceRange(), TextArea.insert(), TextArea.append()/
> In file awt / TextArea.java
> Many Thanks,
> Ambarish Rapte
Best regards, Sergey.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the awt-dev