<AWT Dev> <AWT dev> Review request for JDK-8137137: [macosx] The native dialog doesn't have 'close'(X) button on Mac OS.
prasanta.sadhukhan at oracle.com
Mon Apr 18 10:00:16 UTC 2016
While pressing x button , the test dialog is not closing in windows.
Please check that. Also, the failure message
/throw new RuntimeException("Updating TrayIcon popup menu"//
// + " items FAILED");//
seems to be wrong.
On 4/18/2016 2:59 PM, Manajit Halder wrote:
> Hi Phil,
> Thank you for the review comments. Please review the updated webrev.
>> On 15-Apr-2016, at 11:39 pm, Phil Race <philip.race at oracle.com
>> <mailto:philip.race at oracle.com>> wrote:
>> Good to get rid of one applet test. Only 1,499 to go :-)
>> Even though you effectively re-wrote this you should set the (c) as a range "2007, 2016"
>> Also I think we should try to use the natural size of the component rather than explicitly
>> setting the size :-
>> instructionFrame.setBounds(0, 0, 650, 230);
>> instructionTextArea.setBounds(10, 10, 650, 230);
>> On 04/15/2016 10:53 AM, Manajit Halder wrote:
>>> Hi All,
>>> Kindly review the fix for JDK9.
>>> The native print dialog and native page dialog doesn’t display
>>> close(X) button in Mac OS X.
>>> The reported problem is the expected behaviour on Mac OS. The native
>>> print dialog does not have ‘close’(X) button on MacOS, instead the
>>> dialog contains OK or Cancel buttons and expects either Cancel or OK
>>> button clicks from the user.
>>> The native print dialogs (“native print dialog” and “native page
>>> dialogs”) calls Cocoa method runModalWithPrintInfo on MacOS to
>>> display the print and page dialogs. runModalWithPrintInfo method
>>> does not have any close button and also the normal behaviour of a
>>> modal window is to exclude all other windows and panels from
>>> receiving events. Therefore as long as the print or page dialog
>>> window is open, no other windows will receive any events.
>>> The user is expected to either click OK button or Cancel button (or
>>> press the ESC key) to close the print or page dialog.
>>> No fix required. The code changed for the following reasons:
>>> To add proper instruction with colse(X) button behaviour on Mac OS X.
>>> Rewrite the test case without Applets.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the awt-dev