<AWT Dev> [9] Review request for 8154816: Caps Lock doesn't work as expected when using Pinyin Simplified input method

Alexander Potochkin alexander.potochkin at oracle.com
Thu Jun 23 13:51:32 UTC 2016

Hello Semyon

> Hi Dmitry,
> The fix looks good.

The fix is good for me as well.
> I am only not sure that an applet based test is suitable since applets 
> are deprecated.

The Jtreg manual tests are supposed to be applets.

I consulted with the SQE team,
they have no objections for the applet based tests.

So I think this test is fine.


> --Semyon
> On 6/17/2016 1:45 PM, dmitry markov wrote:
>> Hello,
>> Could you review a fix for jdk9, please?
>>     bug: https://bugs.openjdk.java.net/browse/JDK-8154816
>>     webrev: http://cr.openjdk.java.net/~dmarkov/8154816/webrev.00/
>> Problem description:
>> When Pinyin Simplified input method is selected and 'Caps Lock' is 
>> on, input is switched to latin letters, but letters are entered in 
>> uppercase.
>> Fix:
>> It is necessary to ignore 'Caps Lock' modifier in 
>> CPlatformResponder.handleKeyEvent() method, if Pinyin Simplified 
>> input method is selected and 'Caps Lock' is on.
>> Thanks,
>> Dmitry

More information about the awt-dev mailing list