<AWT Dev> Review Request for 8057574 : inconsistent behavior for setBackground (Windows/Linux)
prem.balakrishnan at oracle.com
Mon May 16 06:12:43 UTC 2016
From: Prem Balakrishnan
Sent: Wednesday, May 11, 2016 5:59 PM
To: Sergey Bylokhov; Ambarish Rapte; awt-dev at openjdk.java.net
Subject: RE: Review Request for 8057574 : inconsistent behavior for setBackground (Windows/Linux)
1. Dialog background color set to SystemColor.control.
2. WWindowPeer extends WPanelPeer, WPanelPeer Initialize() method is called Before we initialize default properties like background/foreground in WWindowPeer, hence getBackground/getForeground calls in WPanelPeer Initialize() method always returns NULL.
I have updated the fix, by moving default initialization to the Base class(WPanelPeer).
Please review the updated fix.
Regression and JCK tests passed without causing any regression with the Updated fix as well.
From: Sergey Bylokhov
Sent: Friday, April 29, 2016 7:28 PM
To: Prem Balakrishnan; Ambarish Rapte; Semyon Sadetsky; awt-dev at openjdk.java.net
Subject: Re: Review Request for 8057574 : inconsistent behavior for setBackground (Windows/Linux)
Thanks for the new version, I just found some issues which I messed in the first version:
- It seems that after the fix the Dialog will use the different background color,(SystemColor.window instead of SystemColor.control).
- There is other similar code like in WPanelPeer, please check in what situation the WPanelPeer get null from the getBackground/getForeground.
It seems that WColor class is used only in this WPanelPeer.
On 29.04.16 8:06, Prem Balakrishnan wrote:
> Hi Sergey,
> Thank you for the Review.
> Update patch as per review comments.
> -----Original Message-----
> From: Sergey Bylokhov
> Sent: Thursday, April 28, 2016 6:16 PM
> To: Prem Balakrishnan; Semyon Sadetsky; Ambarish Rapte;
> awt-dev at openjdk.java.net
> Subject: Re: Review Request for 8057574 : inconsistent behavior for
> setBackground (Windows/Linux)
> Hi, Prem.
> The fix looks fine. But please preserve the comments in
> On 25.04.16 9:00, Prem Balakrishnan wrote:
>> Please review fix for JDK9,
>> inconsistent behavior for setBackground (Windows/Linux)
>> Inconsistency also exists for Foreground and Font properties across
>> platforms (Win and Linux)
>> *Fix: *
>> Uniform behaviour is maintained by making , child component NOT to
>> inherit parent properties (Background, Foreground and Font)
>> across all the platforms(Win/Linux/Mac).
>> *Regression and JCK tests passed without causing any regression with
>> the suggested fix.*
> Best regards, Sergey.
Best regards, Sergey.
More information about the awt-dev