<AWT Dev>  Review Request: 8165769 Hang in the help menu item
Sergey.Bylokhov at oracle.com
Wed Nov 16 13:05:06 UTC 2016
Please review the fix for jdk9.
There are a few issues which can cause a hang in some of our menu stress
- Lack in synchronization in the Menu, we tried to synchronized the
write of fields, but skip synchronization when we read the fields(in
getters for example). In the fix most of the fields were marked as
final(if possible) or volatile.
- When the submenu is removed from Menu/MenuBar we do not reset its
parent field if the Menu/MenuBar have peer==null. So if later we tried
to call MenuBar.setHelpMenu(submenu) we skip this submenu because we
think it was added already.
Webrev can be found at: http://cr.openjdk.java.net/~serb/8165769/webrev.00
Best regards, Sergey.
More information about the awt-dev